The following document contains the results of
Checkstyle.
| Files | Infos | Warnings | Errors |
|---|
| 50 | 0 | 0 | 1329 |
| Error | Line |
|---|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
19
|
|
| Using the '.*' form of import should be avoided - java.io.*. |
20
|
|
| Line has trailing spaces. |
23
|
|
| Line has trailing spaces. |
26
|
|
| Line has trailing spaces. |
30
|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
31
|
|
| Line is longer than 80 characters. |
33
|
|
| Line has trailing spaces. |
36
|
|
| Method 'load' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
| Missing a Javadoc comment. |
37
|
|
| 'if' construct must use '{}'s. |
40
|
|
| Line has trailing spaces. |
46
|
|
| Method 'save' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Missing a Javadoc comment. |
47
|
|
| 'if' construct must use '{}'s. |
50
|
|
| Line is longer than 80 characters. |
54
|
|
| Line is longer than 80 characters. |
61
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
19
|
|
| First sentence should end with a period. |
21
|
|
| Missing a Javadoc comment. |
26
|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
28
|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
32
|
|
| Line has trailing spaces. |
33
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
34
|
|
| Missing a Javadoc comment. |
34
|
|
| Line has trailing spaces. |
45
|
|
| Line contains a tab character. |
46
|
|
| Line contains a tab character. |
47
|
|
| Line contains a tab character. |
48
|
|
| Line contains a tab character. |
49
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
| Line contains a tab character. |
50
|
|
| Line contains a tab character. |
51
|
|
| Line contains a tab character. |
52
|
|
| Line contains a tab character. |
53
|
|
| Line contains a tab character. |
54
|
|
| Line contains a tab character. |
55
|
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
| Parameter name should be final. |
55
|
|
| 'name' hides a field. |
55
|
|
| Line contains a tab character. |
56
|
|
| Line contains a tab character. |
57
|
|
| Line contains a tab character. |
58
|
|
| Line contains a tab character. |
59
|
|
| Line contains a tab character. |
60
|
|
| Line contains a tab character. |
61
|
|
| Method 'getParent' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Line contains a tab character. |
62
|
|
| Line contains a tab character. |
63
|
|
| Line contains a tab character. |
64
|
|
| Line contains a tab character. |
65
|
|
| Line contains a tab character. |
66
|
|
| Line contains a tab character. |
67
|
|
| Method 'setParent' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Parameter parent should be final. |
67
|
|
| 'parent' hides a field. |
67
|
|
| Line contains a tab character. |
68
|
|
| Line contains a tab character. |
69
|
|
| Line contains a tab character. |
70
|
|
| Line contains a tab character. |
71
|
|
| Line contains a tab character. |
72
|
|
| Line contains a tab character. |
73
|
|
| Method 'getRefNumber' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
| Line contains a tab character. |
74
|
|
| Line contains a tab character. |
75
|
|
| Line contains a tab character. |
76
|
|
| Line contains a tab character. |
77
|
|
| Line contains a tab character. |
78
|
|
| Line contains a tab character. |
79
|
|
| Method 'setRefNumber' is not designed for extension - needs to be abstract, final or empty. |
79
|
|
| Parameter refNumber should be final. |
79
|
|
| 'refNumber' hides a field. |
79
|
|
| Line contains a tab character. |
80
|
|
| Line contains a tab character. |
81
|
|
| Line contains a tab character. |
82
|
|
| Line contains a tab character. |
83
|
|
| Line contains a tab character. |
84
|
|
| Line contains a tab character. |
85
|
|
| Method 'getSummary' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
| Line contains a tab character. |
86
|
|
| Line contains a tab character. |
87
|
|
| Line contains a tab character. |
88
|
|
| Line contains a tab character. |
89
|
|
| Line contains a tab character. |
90
|
|
| Line contains a tab character. |
91
|
|
| Method 'setSummary' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
| Parameter summary should be final. |
91
|
|
| 'summary' hides a field. |
91
|
|
| Line contains a tab character. |
92
|
|
| Line contains a tab character. |
93
|
|
| Line contains a tab character. |
94
|
|
| Line contains a tab character. |
95
|
|
| Line contains a tab character. |
96
|
|
| Line contains a tab character. |
97
|
|
| Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
| Line contains a tab character. |
98
|
|
| Line contains a tab character. |
99
|
|
| Line contains a tab character. |
100
|
|
| Line contains a tab character. |
101
|
|
| Line contains a tab character. |
102
|
|
| Line contains a tab character. |
103
|
|
| Method 'setTitle' is not designed for extension - needs to be abstract, final or empty. |
103
|
|
| Parameter title should be final. |
103
|
|
| 'title' hides a field. |
103
|
|
| Line contains a tab character. |
104
|
|
| Line contains a tab character. |
105
|
|
| Line contains a tab character. |
106
|
|
| Line contains a tab character. |
107
|
|
| Line contains a tab character. |
108
|
|
| Line contains a tab character. |
109
|
|
| Method 'getParentAlbum' is not designed for extension - needs to be abstract, final or empty. |
109
|
|
| Line contains a tab character. |
110
|
|
| Line contains a tab character. |
111
|
|
| Line contains a tab character. |
112
|
|
| Line contains a tab character. |
113
|
|
| Line contains a tab character. |
114
|
|
| Line contains a tab character. |
115
|
|
| Method 'setParentAlbum' is not designed for extension - needs to be abstract, final or empty. |
115
|
|
| Parameter parentAlbum should be final. |
115
|
|
| 'parentAlbum' hides a field. |
115
|
|
| Line contains a tab character. |
116
|
|
| Line contains a tab character. |
117
|
|
| Line has trailing spaces. |
118
|
|
| Method 'addPicture' is not designed for extension - needs to be abstract, final or empty. |
119
|
|
| Missing a Javadoc comment. |
119
|
|
| Parameter i should be final. |
119
|
|
| 'if' construct must use '{}'s. |
120
|
|
| Method 'addPictures' is not designed for extension - needs to be abstract, final or empty. |
124
|
|
| Missing a Javadoc comment. |
124
|
|
| Parameter c should be final. |
124
|
|
| 'if' construct must use '{}'s. |
125
|
|
| Method 'getPictures' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| Missing a Javadoc comment. |
129
|
|
| 'if' construct must use '{}'s. |
130
|
|
| Method 'getPictureCount' is not designed for extension - needs to be abstract, final or empty. |
134
|
|
| Missing a Javadoc comment. |
134
|
|
| 'if' construct must use '{}'s. |
135
|
|
| Line contains a tab character. |
136
|
|
| Method 'resetPictures' is not designed for extension - needs to be abstract, final or empty. |
139
|
|
| Missing a Javadoc comment. |
139
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
24
|
|
| Missing a Javadoc comment. |
25
|
|
| Line contains a tab character. |
26
|
|
| Line contains a tab character. |
27
|
|
| Line contains a tab character. |
28
|
|
| Line contains a tab character. |
29
|
|
| Method 'getCaption' is not designed for extension - needs to be abstract, final or empty. |
29
|
|
| Line contains a tab character. |
30
|
|
| Line contains a tab character. |
31
|
|
| Line contains a tab character. |
32
|
|
| Line contains a tab character. |
33
|
|
| Line contains a tab character. |
34
|
|
| Line contains a tab character. |
35
|
|
| Method 'setCaption' is not designed for extension - needs to be abstract, final or empty. |
35
|
|
| Parameter caption should be final. |
35
|
|
| 'caption' hides a field. |
35
|
|
| Line contains a tab character. |
36
|
|
| Line contains a tab character. |
37
|
|
| Line contains a tab character. |
38
|
|
| Line contains a tab character. |
39
|
|
| Line contains a tab character. |
40
|
|
| Line contains a tab character. |
41
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
| Line contains a tab character. |
42
|
|
| Line contains a tab character. |
43
|
|
| Line contains a tab character. |
44
|
|
| Line contains a tab character. |
45
|
|
| Line contains a tab character. |
46
|
|
| Line contains a tab character. |
47
|
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Parameter name should be final. |
47
|
|
| 'name' hides a field. |
47
|
|
| Line contains a tab character. |
48
|
|
| Line contains a tab character. |
49
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
19
|
|
| First sentence should end with a period. |
21
|
|
| Missing a Javadoc comment. |
26
|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
28
|
|
| Line has trailing spaces. |
29
|
|
| Line contains a tab character. |
30
|
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
30
|
|
| Missing a Javadoc comment. |
30
|
|
| 'return' is not preceded with whitespace. |
30
|
|
| '{' is not followed by whitespace. |
30
|
|
| ';' is not followed by whitespace. |
30
|
|
| '}' is not preceded with whitespace. |
30
|
|
| Line contains a tab character. |
31
|
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
31
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter name should be final. |
31
|
|
| 'name' hides a field. |
31
|
|
| '{' is not followed by whitespace. |
31
|
|
| ';' is not followed by whitespace. |
31
|
|
| '}' is not preceded with whitespace. |
31
|
|
| Line contains a tab character. |
32
|
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
32
|
|
| Missing a Javadoc comment. |
32
|
|
| 'return' is not preceded with whitespace. |
32
|
|
| '{' is not followed by whitespace. |
32
|
|
| ';' is not followed by whitespace. |
32
|
|
| '}' is not preceded with whitespace. |
32
|
|
| Line contains a tab character. |
33
|
|
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Parameter type should be final. |
33
|
|
| 'type' hides a field. |
33
|
|
| '{' is not followed by whitespace. |
33
|
|
| ';' is not followed by whitespace. |
33
|
|
| '}' is not preceded with whitespace. |
33
|
|
| Method 'addPicture' is not designed for extension - needs to be abstract, final or empty. |
34
|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter id should be final. |
34
|
|
| '{' is not followed by whitespace. |
34
|
|
| ';' is not followed by whitespace. |
34
|
|
| '}' is not preceded with whitespace. |
34
|
|
| Method 'addPicture' is not designed for extension - needs to be abstract, final or empty. |
35
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter id should be final. |
35
|
|
| '{' is not followed by whitespace. |
35
|
|
| ';' is not followed by whitespace. |
35
|
|
| '}' is not preceded with whitespace. |
35
|
|
| Line is longer than 80 characters. |
36
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
36
|
|
| Missing a Javadoc comment. |
36
|
|
| 'return' is not preceded with whitespace. |
36
|
|
| '{' is not followed by whitespace. |
36
|
|
| ';' is not followed by whitespace. |
36
|
|
| '}' is not preceded with whitespace. |
36
|
|
| Method 'getPictures' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
| Missing a Javadoc comment. |
37
|
|
| 'return' is not preceded with whitespace. |
37
|
|
| '{' is not followed by whitespace. |
37
|
|
| ';' is not followed by whitespace. |
37
|
|
| '}' is not preceded with whitespace. |
37
|
|
| Method 'getPictureCount' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
| Missing a Javadoc comment. |
38
|
|
| 'return' is not preceded with whitespace. |
38
|
|
| '{' is not followed by whitespace. |
38
|
|
| ';' is not followed by whitespace. |
38
|
|
| '}' is not preceded with whitespace. |
38
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
19
|
|
| Missing a Javadoc comment. |
24
|
|
| Missing a Javadoc comment. |
25
|
|
| Missing a Javadoc comment. |
26
|
|
| Line has trailing spaces. |
27
|
|
| Line contains a tab character. |
28
|
|
| Method 'getCaption' is not designed for extension - needs to be abstract, final or empty. |
28
|
|
| Missing a Javadoc comment. |
28
|
|
| 'return' is not preceded with whitespace. |
28
|
|
| '{' is not followed by whitespace. |
28
|
|
| ';' is not followed by whitespace. |
28
|
|
| '}' is not preceded with whitespace. |
28
|
|
| Line contains a tab character. |
29
|
|
| Method 'setCaption' is not designed for extension - needs to be abstract, final or empty. |
29
|
|
| Missing a Javadoc comment. |
29
|
|
| Parameter caption should be final. |
29
|
|
| 'caption' hides a field. |
29
|
|
| '{' is not followed by whitespace. |
29
|
|
| ';' is not followed by whitespace. |
29
|
|
| '}' is not preceded with whitespace. |
29
|
|
| Line contains a tab character. |
30
|
|
| Method 'getFilename' is not designed for extension - needs to be abstract, final or empty. |
30
|
|
| Missing a Javadoc comment. |
30
|
|
| 'return' is not preceded with whitespace. |
30
|
|
| '{' is not followed by whitespace. |
30
|
|
| ';' is not followed by whitespace. |
30
|
|
| '}' is not preceded with whitespace. |
30
|
|
| Line contains a tab character. |
31
|
|
| Method 'setFilename' is not designed for extension - needs to be abstract, final or empty. |
31
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter filename should be final. |
31
|
|
| 'filename' hides a field. |
31
|
|
| '{' is not followed by whitespace. |
31
|
|
| ';' is not followed by whitespace. |
31
|
|
| '}' is not preceded with whitespace. |
31
|
|
| Line contains a tab character. |
32
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
32
|
|
| Missing a Javadoc comment. |
32
|
|
| 'return' is not preceded with whitespace. |
32
|
|
| '{' is not followed by whitespace. |
32
|
|
| ';' is not followed by whitespace. |
32
|
|
| '}' is not preceded with whitespace. |
32
|
|
| Line contains a tab character. |
33
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| Parameter id should be final. |
33
|
|
| 'id' hides a field. |
33
|
|
| '{' is not followed by whitespace. |
33
|
|
| ';' is not followed by whitespace. |
33
|
|
| '}' is not preceded with whitespace. |
33
|
|
| Method 'getIdInt' is not designed for extension - needs to be abstract, final or empty. |
34
|
|
| Missing a Javadoc comment. |
34
|
|
| 'return' is not preceded with whitespace. |
34
|
|
| '{' is not followed by whitespace. |
34
|
|
| ';' is not followed by whitespace. |
34
|
|
| '}' is not preceded with whitespace. |
34
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
35
|
|
| Missing a Javadoc comment. |
35
|
|
| Parameter id should be final. |
35
|
|
| 'id' hides a field. |
35
|
|
| '{' is not followed by whitespace. |
35
|
|
| ';' is not followed by whitespace. |
35
|
|
| '}' is not preceded with whitespace. |
35
|
|
| Line is longer than 80 characters. |
36
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
36
|
|
| Missing a Javadoc comment. |
36
|
|
| 'return' is not preceded with whitespace. |
36
|
|
| '{' is not followed by whitespace. |
36
|
|
| ';' is not followed by whitespace. |
36
|
|
| '}' is not preceded with whitespace. |
36
|
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
26
|
|
| Parameter code should be final. |
26
|
|
| Parameter message should be final. |
26
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| First sentence should end with a period. |
19
|
|
| Missing a Javadoc comment. |
24
|
|
| Variable 'errorCode' must be private and have accessor methods. |
24
|
|
| Missing a Javadoc comment. |
25
|
|
| Variable 'errorMessage' must be private and have accessor methods. |
25
|
|
| Line has trailing spaces. |
26
|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
30
|
|
| Parameter code should be final. |
30
|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter message should be final. |
34
|
|
| Missing a Javadoc comment. |
38
|
|
| Parameter code should be final. |
38
|
|
| Parameter message should be final. |
38
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
| Missing a Javadoc comment. |
43
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
26
|
|
| Parameter code should be final. |
26
|
|
| Parameter message should be final. |
26
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
26
|
|
| Parameter code should be final. |
26
|
|
| Parameter message should be final. |
26
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
19
|
|
| Missing a Javadoc comment. |
20
|
|
| Parameter code should be final. |
20
|
|
| Parameter message should be final. |
20
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
26
|
|
| Parameter code should be final. |
26
|
|
| Parameter message should be final. |
26
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
26
|
|
| Parameter code should be final. |
26
|
|
| Parameter message should be final. |
26
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
26
|
|
| Parameter code should be final. |
26
|
|
| Parameter message should be final. |
26
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
26
|
|
| Parameter code should be final. |
26
|
|
| Parameter message should be final. |
26
|
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.io.*. |
19
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
20
|
|
| Using the '.*' form of import should be avoided - org.ninjasoft.igallery.data.*. |
22
|
|
| Using the '.*' form of import should be avoided - javax.xml.parsers.*. |
26
|
|
| First sentence should end with a period. |
28
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
36
|
|
| Variable 'mode' must be private and have accessor methods. |
36
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
46
|
|
| Line has trailing spaces. |
47
|
|
| Missing a Javadoc comment. |
48
|
|
| 'if' construct must use '{}'s. |
49
|
|
| '60' is a magic number. |
49
|
|
| Line has trailing spaces. |
52
|
|
| Line is longer than 80 characters. |
53
|
|
| Line contains a tab character. |
53
|
|
| Method 'startElement' is not designed for extension - needs to be abstract, final or empty. |
53
|
|
| Missing a Javadoc comment. |
53
|
|
| Parameter uri should be final. |
53
|
|
| Parameter localName should be final. |
53
|
|
| Parameter qName should be final. |
53
|
|
| Parameter attributes should be final. |
53
|
|
| Line contains a tab character. |
54
|
|
| 'if' construct must use '{}'s. |
56
|
|
| 'if' construct must use '{}'s. |
58
|
|
| 'if' construct must use '{}'s. |
60
|
|
| 'if' construct must use '{}'s. |
63
|
|
| Line contains a tab character. |
66
|
|
| Line is longer than 80 characters. |
67
|
|
| Method 'endElement' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Missing a Javadoc comment. |
67
|
|
| Parameter uri should be final. |
67
|
|
| Parameter localName should be final. |
67
|
|
| Parameter qName should be final. |
67
|
|
| Line is longer than 80 characters. |
76
|
|
| Line has trailing spaces. |
88
|
|
| Line is longer than 80 characters. |
88
|
|
| 'if' construct must use '{}'s. |
92
|
|
| 'if' construct must use '{}'s. |
94
|
|
| 'if' construct must use '{}'s. |
96
|
|
| 'try' is not followed by whitespace. |
103
|
|
| '{' is not preceded with whitespace. |
103
|
|
| 'catch' is not preceded with whitespace. |
105
|
|
| '}' is not followed by whitespace. |
105
|
|
| 'catch' is not followed by whitespace. |
105
|
|
| '{' is not preceded with whitespace. |
105
|
|
| Must have at least one statement. |
105
|
|
| '{' is not followed by whitespace. |
105
|
|
| '}' is not preceded with whitespace. |
105
|
|
| 'if' construct must use '{}'s. |
106
|
|
| 'if' construct must use '{}'s. |
110
|
|
| Line is longer than 80 characters. |
123
|
|
| 'try' is not followed by whitespace. |
126
|
|
| '{' is not preceded with whitespace. |
126
|
|
| 'catch' is not preceded with whitespace. |
128
|
|
| '}' is not followed by whitespace. |
128
|
|
| 'catch' is not followed by whitespace. |
128
|
|
| '{' is not preceded with whitespace. |
128
|
|
| Must have at least one statement. |
128
|
|
| '{' is not followed by whitespace. |
128
|
|
| '}' is not preceded with whitespace. |
128
|
|
| Line contains a tab character. |
130
|
|
| Line contains a tab character. |
131
|
|
| Line is longer than 80 characters. |
139
|
|
| 'if' construct must use '{}'s. |
141
|
|
| 'if' construct must use '{}'s. |
143
|
|
| Line is longer than 80 characters. |
157
|
|
| Method 'characters' is not designed for extension - needs to be abstract, final or empty. |
157
|
|
| Missing a Javadoc comment. |
157
|
|
| Parameter data should be final. |
157
|
|
| Parameter start should be final. |
157
|
|
| Parameter length should be final. |
157
|
|
| 'if' construct must use '{}'s. |
159
|
|
| Line has trailing spaces. |
162
|
|
| Method 'getAlbums' is not designed for extension - needs to be abstract, final or empty. |
163
|
|
| Missing a Javadoc comment. |
163
|
|
| Line has trailing spaces. |
166
|
|
| Method 'getPictureHash' is not designed for extension - needs to be abstract, final or empty. |
167
|
|
| Missing a Javadoc comment. |
167
|
|
| Line has trailing spaces. |
170
|
|
| Missing a Javadoc comment. |
171
|
|
| Parameter argv should be final. |
171
|
|
| Line has trailing spaces. |
175
|
|
| Line is longer than 80 characters. |
177
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
19
|
|
| Using the '.*' form of import should be avoided - java.net.*. |
20
|
|
| First sentence should end with a period. |
22
|
|
| Missing a Javadoc comment. |
27
|
|
| Missing a Javadoc comment. |
28
|
|
| Name 'DEBUG' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
28
|
|
| Variable 'DEBUG' must be private and have accessor methods. |
28
|
|
| Line has trailing spaces. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| Line has trailing spaces. |
31
|
|
| First sentence should end with a period. |
32
|
|
| Method 'grabCookies' is not designed for extension - needs to be abstract, final or empty. |
37
|
|
| Parameter connection should be final. |
37
|
|
| Expected @param tag for 'connection'. |
37
|
|
| Line has trailing spaces. |
49
|
|
| Method 'setCookies' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Parameter connection should be final. |
54
|
|
| Expected @param tag for 'connection'. |
54
|
|
| ')' is preceded with whitespace. |
54
|
|
| ';' is followed by whitespace. |
55
|
|
| 'if' construct must use '{}'s. |
57
|
|
| Line contains a tab character. |
58
|
|
| Line has trailing spaces. |
62
|
|
| Line has trailing spaces. |
63
|
|
| Missing a Javadoc comment. |
64
|
|
| Parameter cookieData should be final. |
64
|
|
| Comment matches to-do format 'TODO:'. |
65
|
|
| 'if' construct must use '{}'s. |
67
|
|
| '+' is not preceded with whitespace. |
71
|
|
| '+' is not followed by whitespace. |
71
|
|
| '=' is not preceded with whitespace. |
73
|
|
| '=' is not followed by whitespace. |
73
|
|
| '<' is not preceded with whitespace. |
73
|
|
| '<' is not followed by whitespace. |
73
|
|
| 'if' construct must use '{}'s. |
76
|
|
| 'if' construct must use '{}'s. |
82
|
|
| Line has trailing spaces. |
86
|
|
| Missing a Javadoc comment. |
87
|
|
| Comment matches to-do format 'TODO:'. |
88
|
|
| Line has trailing spaces. |
88
|
|
| Line has trailing spaces. |
90
|
|
| Method 'setStatusListener' is not designed for extension - needs to be abstract, final or empty. |
91
|
|
| Missing a Javadoc comment. |
91
|
|
| Parameter l should be final. |
91
|
|
| '{' is not followed by whitespace. |
91
|
|
| ';' is not followed by whitespace. |
91
|
|
| '}' is not preceded with whitespace. |
91
|
|
| Missing a Javadoc comment. |
93
|
|
| Parameter message should be final. |
93
|
|
| 'if' construct must use '{}'s. |
94
|
|
| Missing a Javadoc comment. |
97
|
|
| Parameter message should be final. |
97
|
|
| 'if' construct must use '{}'s. |
98
|
| Error | Line |
|---|
|
| Line does not match expected header line of ' GNU GENERAL PUBLIC LICENSE'. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
19
|
|
| Using the '.*' form of import should be avoided - java.net.*. |
20
|
|
| Using the '.*' form of import should be avoided - java.io.*. |
21
|
|
| Using the '.*' form of import should be avoided - org.ninjasoft.igallery.exceptions.*. |
23
|
|
| Using the '.*' form of import should be avoided - org.ninjasoft.igallery.data.*. |
24
|
|
| First sentence should end with a period. |
26
|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Name 'DEBUG' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
34
|
|
| Variable 'DEBUG' must be private and have accessor methods. |
34
|
|
| Line has trailing spaces. |
35
|
|
| Missing a Javadoc comment. |
36
|
|
| Parameter url should be final. |
36
|
|
| 'url' hides a field. |
36
|
|
| Line has trailing spaces. |
39
|
|
| Line is longer than 80 characters. |
40
|
|
| Missing a Javadoc comment. |
40
|
|
| Parameter url should be final. |
40
|
|
| 'url' hides a field. |
40
|
|
| Parameter listener should be final. |
40
|
|
| 'listener' hides a field. |
40
|
|
| 'if' construct must use '{}'s. |
43
|
|
| Line is longer than 80 characters. |
44
|
|
| Line has trailing spaces. |
46
|
|
| Line is longer than 80 characters. |
48
|
|
| Line is longer than 80 characters. |
49
|
|
| Line is longer than 80 characters. |
50
|
|
| Expected an @return tag. |
58
|
|
| Line is longer than 80 characters. |
58
|
|
| Method 'login' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Parameter username should be final. |
58
|
|
| Expected @param tag for 'username'. |
58
|
|
| Parameter password should be final. |
58
|
|
| Expected @param tag for 'password'. |
58
|
|
| Expected @throws tag for 'IOException'. |
58
|
|
| Expected @throws tag for 'GalleryException'. |
58
|
|
| Line has trailing spaces. |
66
|
|
| Line has trailing spaces. |
69
|
|
| Line has trailing spaces. |
71
|
|
| Method 'getAlbumList' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Expected @throws tag for 'IOException'. |
76
|
|
| Expected @throws tag for 'GalleryException'. |
76
|
|
| Line has trailing spaces. |
85
|
|
| Expected an @return tag. |
95
|
|
| Parameter data should be final. |
95
|
|
| Expected @param tag for 'data'. |
95
|
|
| 'try' is not followed by whitespace. |
98
|
|
| '{' is not preceded with whitespace. |
98
|
|
| Line is longer than 80 characters. |
99
|
|
| Line contains a tab character. |
99
|
|
| 'catch' is not preceded with whitespace. |
100
|
|
| '}' is not followed by whitespace. |
100
|
|
| 'catch' is not followed by whitespace. |
100
|
|
| '{' is not preceded with whitespace. |
100
|
|
| Must have at least one statement. |
100
|
|
| '{' is not followed by whitespace. |
100
|
|
| '}' is not preceded with whitespace. |
100
|
|
| '=' is not preceded with whitespace. |
102
|
|
| '=' is not followed by whitespace. |
102
|
|
| '<=' is not preceded with whitespace. |
102
|
|
| '<=' is not followed by whitespace. |
102
|
|
| Line is longer than 80 characters. |
111
|
|
| ';' is followed by whitespace. |
112
|
|
| 'try' is not followed by whitespace. |
115
|
|
| '{' is not preceded with whitespace. |
115
|
|
| Line contains a tab character. |
116
|
|
| 'catch' is not preceded with whitespace. |
117
|
|
| '}' is not followed by whitespace. |
117
|
|
| 'catch' is not followed by whitespace. |
117
|
|
| '{' is not preceded with whitespace. |
117
|
|
| Must have at least one statement. |
117
|
|
| '{' is not followed by whitespace. |
117
|
|
| '}' is not preceded with whitespace. |
117
|
|
| 'if' construct must use '{}'s. |
118
|
|
| Line has trailing spaces. |
123
|
|
| Line is longer than 80 characters. |
124
|
|
| Method 'uploadPhoto' is not designed for extension - needs to be abstract, final or empty. |
124
|
|
| Missing a Javadoc comment. |
124
|
|
| Parameter album should be final. |
124
|
|
| Parameter image should be final. |
124
|
|
| Parameter name should be final. |
124
|
|
| Parameter caption should be final. |
124
|
|
| 'if' construct must use '{}'s. |
132
|
|
| Line has trailing spaces. |
137
|
|
| Line has trailing spaces. |
139
|
|
| Expected an @return tag. |
144
|
|
| Method 'encodeFileContent' is not designed for extension - needs to be abstract, final or empty. |
144
|
|
| Parameter f should be final. |
144
|
|
| Expected @param tag for 'f'. |
144
|
|
| Expected @throws tag for 'IOException'. |
144
|
|
| '(' is followed by whitespace. |
150
|
|
| '||' should be on a new line. |
150
|
|
| '||' should be on a new line. |
151
|
|
| Line contains a tab character. |
154
|
|
| '16' is a magic number. |
157
|
|
| 'if' construct must use '{}'s. |
158
|
|
| Line has trailing spaces. |
166
|
|
| Line has trailing spaces. |
168
|
|
| Expected an @return tag. |
173
|
|
| Method 'fileContent' is not designed for extension - needs to be abstract, final or empty. |
173
|
|
| Parameter f should be final. |
173
|
|
| Expected @param tag for 'f'. |
173
|
|
| Expected @throws tag for 'IOException'. |
173
|
|
| '1024' is a magic number. |
176
|
|
| 'while' construct must use '{}'s. |
178
|
|
| Line is longer than 80 characters. |
192
|
|
| Method 'getPhotoList' is not designed for extension - needs to be abstract, final or empty. |
192
|
|
| Parameter album should be final. |
192
|
|
| Expected @param tag for 'album'. |
192
|
|
| Expected @throws tag for 'IOException'. |
192
|
|
| Expected @throws tag for 'GalleryException'. |
192
|
|
| Line has trailing spaces. |
202
|
|
| Expected an @return tag. |
210
|
|
| Parameter data should be final. |
210
|
|
| Expected @param tag for 'data'. |
210
|
|
| 'try' is not followed by whitespace. |
213
|
|
| '{' is not preceded with whitespace. |
213
|
|
| 'catch' is not preceded with whitespace. |
215
|
|
| '}' is not followed by whitespace. |
215
|
|
| 'catch' is not followed by whitespace. |
215
|
|
| '{' is not preceded with whitespace. |
215
|
|
| Must have at least one statement. |
215
|
|
| '{' is not followed by whitespace. |
215
|
|
| '}' is not preceded with whitespace. |
215
|
|
| '=' is not preceded with whitespace. |
217
|
|
| '=' is not followed by whitespace. |
217
|
|
| '<=' is not preceded with whitespace. |
217
|
|
| '<=' is not followed by whitespace. |
217
|
|
| '=' is not preceded with whitespace. |
218
|
|
| Line is longer than 80 characters. |
227
|
|
| Parameter data should be final. |
232
|
|
| Expected @param tag for 'data'. |
232
|
|
| Expected @throws tag for 'GalleryException'. |
232
|
|
| 'try' is not followed by whitespace. |
236
|
|
| '{' is not preceded with whitespace. |
236
|
|
| Line contains a tab character. |
237
|
|
| 'catch' is not preceded with whitespace. |
238
|
|
| '}' is not followed by whitespace. |
238
|
|
| 'catch' is not followed by whitespace. |
238
|
|
| '{' is not preceded with whitespace. |
238
|
|
| Must have at least one statement. |
238
|
|
| '{' is not followed by whitespace. |
238
|
|
| '}' is not preceded with whitespace. |
238
|
|
| 'if' construct must use '{}'s. |
239
|
|
| Line contains a tab character. |
240
|
|
| 'if' construct must use '{}'s. |
241
|
|
| 'if' construct must use '{}'s. |
243
|
|
| '101' is a magic number. |
246
|
|
| '102' is a magic number. |
247
|
|
| '103' is a magic number. |
248
|
|
| '104' is a magic number. |
249
|
|
| '201' is a magic number. |
251
|
|
| '202' is a magic number. |
252
|
|
| '301' is a magic number. |
254
|
|
| '401' is a magic number. |
256
|
|
| '404' is a magic number. |
257
|
|
| '501' is a magic number. |
258
|
|
| '402' is a magic number. |
260
|
|
| '403' is a magic number. |
262
|
|
| '502' is a magic number. |
264
|
|
| Line has trailing spaces. |
270
|
|
| Line is longer than 80 characters. |
272
|
|
| Expected an @return tag. |
279
|
|
| Line is longer than 80 characters. |
279
|
|
| Parameter parameters should be final. |
279
|
|
| Expected @param tag for 'parameters'. |
279
|
|
| Expected @throws tag for 'IOException'. |
279
|
|
| Expected @throws tag for 'GalleryException'. |
279
|
|
| Line is longer than 80 characters. |
281
|
|
| Line is longer than 80 characters. |
286
|
|
| '200' is a magic number. |
298
|
|
| Line has trailing spaces. |
299
|
|
| Line is longer than 80 characters. |
299
|
|
| '+' should be on a new line. |
299
|
|
| '+' should be on a new line. |
300
|
|
| Line has trailing spaces. |
308
|
|
| First sentence should end with a period. |
309
|
|
| Expected an @return tag. |
315
|
|
| Parameter in should be final. |
315
|
|
| Expected @param tag for 'in'. |
315
|
|
| Expected @throws tag for 'IOException'. |
315
|
|
| Array brackets at illegal position. |
320
|
|
| '1024' is a magic number. |
320
|
|
| 'while' construct must use '{}'s. |
322
|
|
| Line contains a tab character. |
326
|
|
| Line contains a tab character. |
327
|
|
| Comment matches to-do format 'TODO:'. |
331
|
|
| Line has trailing spaces. |
335
|
|
| Expected an @return tag. |
342
|
|
| Line is longer than 80 characters. |
342
|
|
| Parameter properties should be final. |
342
|
|
| Expected @param tag for 'properties'. |
342
|
|
| Expected @throws tag for 'UnsupportedEncodingException'. |
342
|
|
| ';' is followed by whitespace. |
344
|
|
| Line has trailing spaces. |
354
|
|
| Line is longer than 80 characters. |
355
|
|
| Missing a Javadoc comment. |
355
|
|
| Parameter properties should be final. |
355
|
|
| Parameter boundary should be final. |
355
|
|
| ';' is followed by whitespace. |
357
|
|
| Line contains a tab character. |
373
|
|
| 'if' construct must use '{}'s. |
381
|
|
| Line contains a tab character. |
382
|
|
| 'if' construct must use '{}'s. |
383
|
|
| Line has trailing spaces. |
392
|
|
| First sentence should end with a period. |
393
|
|
| Parameter argv should be final. |
398
|
|
| Expected @param tag for 'argv'. |
398
|
|
| Expected @throws tag for 'Exception'. |
398
|
|
| Line is longer than 80 characters. |
399
|
|
| ';' is followed by whitespace. |
402
|
|
| Line is longer than 80 characters. |
407
|
|
| Line is longer than 80 characters. |
409
|
|
| Method 'setStatusListener' is not designed for extension - needs to be abstract, final or empty. |
412
|
|
| Missing a Javadoc comment. |
412
|
|
| Parameter l should be final. |
412
|
|
| '{' is not followed by whitespace. |
412
|
|
| ';' is not followed by whitespace. |
412
|
|
| '}' is not preceded with whitespace. |
412
|
|
| Missing a Javadoc comment. |
414
|
|
| Parameter message should be final. |
414
|
|
| 'if' construct must use '{}'s. |
415
|
|
| Missing a Javadoc comment. |
418
|
|
| Parameter message should be final. |
418
|
|
| 'if' construct must use '{}'s. |
419
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
19
|
|
| Using the '.*' form of import should be avoided - java.io.*. |
20
|
|
| Using the '.*' form of import should be avoided - javax.xml.parsers.*. |
21
|
|
| Using the '.*' form of import should be avoided - org.ninjasoft.igallery.data.*. |
22
|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
36
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
39
|
|
| Line has trailing spaces. |
40
|
|
| Missing a Javadoc comment. |
41
|
|
| Parameter listener should be final. |
41
|
|
| 'listener' hides a field. |
41
|
|
| Line has trailing spaces. |
44
|
|
| Method 'loadIPhotoAlbums' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Missing a Javadoc comment. |
45
|
|
| Line is longer than 80 characters. |
50
|
|
| Line is longer than 80 characters. |
52
|
|
| 'try' is not followed by whitespace. |
55
|
|
| '{' is not preceded with whitespace. |
55
|
|
| Line has trailing spaces. |
57
|
|
| 'catch' is not preceded with whitespace. |
59
|
|
| '}' is not followed by whitespace. |
59
|
|
| 'catch' is not followed by whitespace. |
59
|
|
| '{' is not preceded with whitespace. |
59
|
|
| Line is longer than 80 characters. |
64
|
|
| Line has trailing spaces. |
69
|
|
| Method 'login' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Missing a Javadoc comment. |
70
|
|
| Parameter url should be final. |
70
|
|
| 'url' hides a field. |
70
|
|
| Parameter username should be final. |
70
|
|
| 'username' hides a field. |
70
|
|
| Parameter password should be final. |
70
|
|
| 'password' hides a field. |
70
|
|
| 'try' is not followed by whitespace. |
72
|
|
| '{' is not preceded with whitespace. |
72
|
|
| Line contains a tab character. |
73
|
|
| Line contains a tab character. |
74
|
|
| 'catch' is not preceded with whitespace. |
75
|
|
| '}' is not followed by whitespace. |
75
|
|
| 'catch' is not followed by whitespace. |
75
|
|
| 'try' is not followed by whitespace. |
81
|
|
| '{' is not preceded with whitespace. |
81
|
|
| Line contains a tab character. |
83
|
|
| 'catch' is not preceded with whitespace. |
86
|
|
| '}' is not followed by whitespace. |
86
|
|
| 'catch' is not followed by whitespace. |
86
|
|
| '{' is not preceded with whitespace. |
86
|
|
| Line has trailing spaces. |
93
|
|
| Method 'getAlbumDetails' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| Missing a Javadoc comment. |
94
|
|
| Line contains a tab character. |
95
|
|
| ';' is followed by whitespace. |
95
|
|
| 'if' construct must use '{}'s. |
97
|
|
| 'try' is not followed by whitespace. |
99
|
|
| '{' is not preceded with whitespace. |
99
|
|
| Line contains a tab character. |
101
|
|
| 'catch' is not preceded with whitespace. |
103
|
|
| '}' is not followed by whitespace. |
103
|
|
| 'catch' is not followed by whitespace. |
103
|
|
| '{' is not preceded with whitespace. |
103
|
|
| Line has trailing spaces. |
112
|
|
| Line is longer than 80 characters. |
113
|
|
| Method 'compareAlbums' is not designed for extension - needs to be abstract, final or empty. |
113
|
|
| Missing a Javadoc comment. |
113
|
|
| Parameter iPhotoAlbum should be final. |
113
|
|
| Parameter galleryAlbum should be final. |
113
|
|
| 'iPhotoPictures' hides a field. |
114
|
|
| Line is longer than 80 characters. |
118
|
|
| ';' is followed by whitespace. |
120
|
|
| Line is longer than 80 characters. |
123
|
|
| ';' is followed by whitespace. |
125
|
|
| 'if' construct must use '{}'s. |
132
|
|
| ';' is followed by whitespace. |
136
|
|
| ';' is followed by whitespace. |
139
|
|
| Line is longer than 80 characters. |
141
|
|
| 'if' construct must use '{}'s. |
148
|
|
| Line has trailing spaces. |
152
|
|
| Method 'logout' is not designed for extension - needs to be abstract, final or empty. |
153
|
|
| Missing a Javadoc comment. |
153
|
|
| Line has trailing spaces. |
157
|
|
| Method 'upload' is not designed for extension - needs to be abstract, final or empty. |
158
|
|
| Missing a Javadoc comment. |
158
|
|
| Parameter remoteAlbum should be final. |
158
|
|
| Parameter localAlbum should be final. |
158
|
|
| Line has trailing spaces. |
161
|
|
| Method 'upload' is not designed for extension - needs to be abstract, final or empty. |
162
|
|
| Missing a Javadoc comment. |
162
|
|
| Parameter album should be final. |
162
|
|
| Parameter picture should be final. |
162
|
|
| 'try' is not followed by whitespace. |
163
|
|
| '{' is not preceded with whitespace. |
163
|
|
| Line contains a tab character. |
164
|
|
| Line is longer than 80 characters. |
165
|
|
| Line contains a tab character. |
165
|
|
| 'catch' is not preceded with whitespace. |
167
|
|
| '}' is not followed by whitespace. |
167
|
|
| 'catch' is not followed by whitespace. |
167
|
|
| '{' is not preceded with whitespace. |
167
|
|
| Line has trailing spaces. |
173
|
|
| Method 'cancel' is not designed for extension - needs to be abstract, final or empty. |
174
|
|
| Missing a Javadoc comment. |
174
|
|
| Line has trailing spaces. |
178
|
|
| Missing a Javadoc comment. |
179
|
|
| Parameter message should be final. |
179
|
|
| 'if' construct must use '{}'s. |
180
|
|
| Missing a Javadoc comment. |
183
|
|
| Parameter message should be final. |
183
|
|
| 'if' construct must use '{}'s. |
184
|
|
| Line has trailing spaces. |
187
|
|
| Missing a Javadoc comment. |
188
|
|
| Parameter b should be final. |
188
|
|
| 'if' construct must use '{}'s. |
189
|
|
| Line has trailing spaces. |
192
|
|
| Method 'getGalleryAlbums' is not designed for extension - needs to be abstract, final or empty. |
193
|
|
| Missing a Javadoc comment. |
193
|
|
| 'return' is not preceded with whitespace. |
193
|
|
| '{' is not followed by whitespace. |
193
|
|
| ';' is not followed by whitespace. |
193
|
|
| '}' is not preceded with whitespace. |
193
|
|
| Method 'getIPhotoAlbums' is not designed for extension - needs to be abstract, final or empty. |
194
|
|
| Missing a Javadoc comment. |
194
|
|
| 'return' is not preceded with whitespace. |
194
|
|
| '{' is not followed by whitespace. |
194
|
|
| ';' is not followed by whitespace. |
194
|
|
| '}' is not preceded with whitespace. |
194
|
|
| Method 'getMissingLocal' is not designed for extension - needs to be abstract, final or empty. |
195
|
|
| Missing a Javadoc comment. |
195
|
|
| 'return' is not preceded with whitespace. |
195
|
|
| '{' is not followed by whitespace. |
195
|
|
| ';' is not followed by whitespace. |
195
|
|
| '}' is not preceded with whitespace. |
195
|
|
| Method 'getMissingRemote' is not designed for extension - needs to be abstract, final or empty. |
196
|
|
| Missing a Javadoc comment. |
196
|
|
| 'return' is not preceded with whitespace. |
196
|
|
| '{' is not followed by whitespace. |
196
|
|
| ';' is not followed by whitespace. |
196
|
|
| '}' is not preceded with whitespace. |
196
|
|
| Line has trailing spaces. |
197
|
|
| Missing a Javadoc comment. |
198
|
|
| Missing a Javadoc comment. |
199
|
|
| Missing a Javadoc comment. |
200
|
|
| Line has trailing spaces. |
201
|
|
| Missing a Javadoc comment. |
202
|
|
| Parameter remoteAlbum should be final. |
202
|
|
| 'remoteAlbum' hides a field. |
202
|
|
| Parameter localAlbum should be final. |
202
|
|
| 'localAlbum' hides a field. |
202
|
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
206
|
|
| Missing a Javadoc comment. |
206
|
|
| Line is longer than 80 characters. |
211
|
|
| Avoid inline conditionals. |
211
|
|
| Line is longer than 80 characters. |
215
|
|
| ';' is followed by whitespace. |
215
|
|
| Line is longer than 80 characters. |
217
|
|
| 'if' construct must use '{}'s. |
221
|
|
| Line is longer than 80 characters. |
225
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Missing a Javadoc comment. |
23
|
|
| Redundant 'public' modifier. |
23
|
|
| Missing a Javadoc comment. |
24
|
|
| Redundant 'public' modifier. |
24
|
|
| Missing a Javadoc comment. |
25
|
|
| Redundant 'public' modifier. |
25
|
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
19
|
|
| Using the '.*' form of import should be avoided - javax.swing.event.*. |
20
|
|
| Using the '.*' form of import should be avoided - org.ninjasoft.igallery.data.*. |
22
|
|
| First sentence should end with a period. |
24
|
|
| Missing a Javadoc comment. |
29
|
|
| Variable 'listeners' must be private and have accessor methods. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| Variable 'albumList' must be private and have accessor methods. |
30
|
|
| Line has trailing spaces. |
31
|
|
| Method 'setAlbumList' is not designed for extension - needs to be abstract, final or empty. |
32
|
|
| Missing a Javadoc comment. |
32
|
|
| Parameter list should be final. |
32
|
|
| Method 'tellChanged' is not designed for extension - needs to be abstract, final or empty. |
36
|
|
| Missing a Javadoc comment. |
36
|
|
| 'for' construct must use '{}'s. |
38
|
|
| ';' is followed by whitespace. |
38
|
|
| Method 'addTableModelListener' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
| Missing a Javadoc comment. |
41
|
|
| Parameter l should be final. |
41
|
|
| Method 'getColumnClass' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter i should be final. |
44
|
|
| Method 'getColumnCount' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Missing a Javadoc comment. |
47
|
|
| Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
| Missing a Javadoc comment. |
50
|
|
| Parameter i should be final. |
50
|
|
| 'if' construct must use '{}'s. |
51
|
|
| '==' is not preceded with whitespace. |
51
|
|
| '==' is not followed by whitespace. |
51
|
|
| Method 'getRowCount' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
| Missing a Javadoc comment. |
55
|
|
| Method 'getValueAt' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Missing a Javadoc comment. |
58
|
|
| Parameter row should be final. |
58
|
|
| Parameter column should be final. |
58
|
|
| 'if' construct must use '{}'s. |
60
|
|
| 'if' construct must use '{}'s. |
63
|
|
| Method 'isCellEditable' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Missing a Javadoc comment. |
67
|
|
| Parameter arg0 should be final. |
67
|
|
| Parameter arg1 should be final. |
67
|
|
| Method 'removeTableModelListener' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Missing a Javadoc comment. |
70
|
|
| Parameter l should be final. |
70
|
|
| Missing a Javadoc comment. |
73
|
|
| Parameter arg0 should be final. |
73
|
|
| Parameter arg1 should be final. |
73
|
|
| Parameter arg2 should be final. |
73
|
|
| Line has trailing spaces. |
74
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
19
|
|
| Using the '.*' form of import should be avoided - javax.swing.event.*. |
20
|
|
| Using the '.*' form of import should be avoided - org.ninjasoft.igallery.data.*. |
22
|
|
| First sentence should end with a period. |
24
|
|
| Missing a Javadoc comment. |
29
|
|
| Variable 'listeners' must be private and have accessor methods. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| Variable 'albumList' must be private and have accessor methods. |
30
|
|
| Line has trailing spaces. |
31
|
|
| Method 'setAlbumList' is not designed for extension - needs to be abstract, final or empty. |
32
|
|
| Missing a Javadoc comment. |
32
|
|
| Parameter list should be final. |
32
|
|
| 'for' construct must use '{}'s. |
35
|
|
| ';' is followed by whitespace. |
35
|
|
| Line has trailing spaces. |
38
|
|
| Line contains a tab character. |
39
|
|
| Method 'addTableModelListener' is not designed for extension - needs to be abstract, final or empty. |
39
|
|
| Missing a Javadoc comment. |
39
|
|
| Parameter l should be final. |
39
|
|
| Line contains a tab character. |
40
|
|
| Line contains a tab character. |
41
|
|
| Line contains a tab character. |
42
|
|
| Method 'getColumnClass' is not designed for extension - needs to be abstract, final or empty. |
42
|
|
| Missing a Javadoc comment. |
42
|
|
| Parameter i should be final. |
42
|
|
| 'if' construct must use '{}'s. |
43
|
|
| Line contains a tab character. |
43
|
|
| Line contains a tab character. |
46
|
|
| Line contains a tab character. |
47
|
|
| Method 'getColumnCount' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Missing a Javadoc comment. |
47
|
|
| Line contains a tab character. |
48
|
|
| Line contains a tab character. |
49
|
|
| Line contains a tab character. |
50
|
|
| Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
| Missing a Javadoc comment. |
50
|
|
| Parameter i should be final. |
50
|
|
| 'if' construct must use '{}'s. |
51
|
|
| '==' is not preceded with whitespace. |
51
|
|
| '==' is not followed by whitespace. |
51
|
|
| Line contains a tab character. |
54
|
|
| Line contains a tab character. |
55
|
|
| Method 'getRowCount' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
| Missing a Javadoc comment. |
55
|
|
| Line contains a tab character. |
57
|
|
| Line contains a tab character. |
58
|
|
| Method 'getValueAt' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Missing a Javadoc comment. |
58
|
|
| Parameter row should be final. |
58
|
|
| Parameter column should be final. |
58
|
|
| 'if' construct must use '{}'s. |
60
|
|
| Line contains a tab character. |
63
|
|
| Line contains a tab character. |
64
|
|
| Method 'isCellEditable' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Missing a Javadoc comment. |
64
|
|
| Parameter arg0 should be final. |
64
|
|
| Parameter arg1 should be final. |
64
|
|
| Line contains a tab character. |
65
|
|
| Line contains a tab character. |
66
|
|
| Line contains a tab character. |
67
|
|
| Method 'removeTableModelListener' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Missing a Javadoc comment. |
67
|
|
| Parameter l should be final. |
67
|
|
| Line contains a tab character. |
68
|
|
| Line contains a tab character. |
69
|
|
| Line contains a tab character. |
70
|
|
| Missing a Javadoc comment. |
70
|
|
| Parameter arg0 should be final. |
70
|
|
| Parameter arg1 should be final. |
70
|
|
| Parameter arg2 should be final. |
70
|
|
| Line has trailing spaces. |
71
|
|
| Line contains a tab character. |
71
|
|
| Line contains a tab character. |
72
|
| Error | Line |
|---|
|
| Line does not match expected header line of ' GNU GENERAL PUBLIC LICENSE'. |
1
|
|
| Using the '.*' form of import should be avoided - java.io.*. |
19
|
|
| Using the '.*' form of import should be avoided - java.util.*. |
20
|
|
| Using the '.*' form of import should be avoided - java.awt.*. |
22
|
|
| Using the '.*' form of import should be avoided - java.awt.event.*. |
23
|
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
24
|
|
| Using the '.*' form of import should be avoided - javax.swing.event.*. |
25
|
|
| Using the '.*' form of import should be avoided - javax.swing.table.*. |
26
|
|
| Using the '.*' form of import should be avoided - org.ninjasoft.igallery.logic.*. |
28
|
|
| Using the '.*' form of import should be avoided - org.ninjasoft.igallery.data.*. |
29
|
|
| Using the '.*' form of import should be avoided - com.apple.eawt.*. |
31
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
36
|
|
| Missing a Javadoc comment. |
37
|
|
| Missing a Javadoc comment. |
38
|
|
| Missing a Javadoc comment. |
39
|
|
| Missing a Javadoc comment. |
40
|
|
| Missing a Javadoc comment. |
41
|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
47
|
|
| Missing a Javadoc comment. |
48
|
|
| Missing a Javadoc comment. |
49
|
|
| Missing a Javadoc comment. |
50
|
|
| Missing a Javadoc comment. |
51
|
|
| Missing a Javadoc comment. |
52
|
|
| Missing a Javadoc comment. |
53
|
|
| Missing a Javadoc comment. |
54
|
|
| Missing a Javadoc comment. |
55
|
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
57
|
|
| Missing a Javadoc comment. |
57
|
|
| 'if' construct must use '{}'s. |
58
|
|
| Line has trailing spaces. |
71
|
|
| Missing a Javadoc comment. |
72
|
|
| '500' is a magic number. |
73
|
|
| '400' is a magic number. |
73
|
|
| Line is longer than 80 characters. |
77
|
|
| '/' is not preceded with whitespace. |
77
|
|
| '/' is not followed by whitespace. |
77
|
|
| '/' is not preceded with whitespace. |
77
|
|
| '/' is not followed by whitespace. |
77
|
|
| '/' is not preceded with whitespace. |
77
|
|
| '/' is not followed by whitespace. |
77
|
|
| '/' is not preceded with whitespace. |
77
|
|
| '/' is not followed by whitespace. |
77
|
|
| '9' is a magic number. |
78
|
|
| '4' is a magic number. |
82
|
|
| Line is longer than 80 characters. |
85
|
|
| Line is longer than 80 characters. |
86
|
|
| Line is longer than 80 characters. |
91
|
|
| Line is longer than 80 characters. |
92
|
|
| Line is longer than 80 characters. |
93
|
|
| Method 'getTableCellRendererComponent' is not designed for extension - needs to be abstract, final or empty. |
93
|
|
| Parameter table should be final. |
93
|
|
| Parameter value should be final. |
93
|
|
| Parameter isSelected should be final. |
93
|
|
| Parameter hasFocus should be final. |
93
|
|
| Parameter row should be final. |
93
|
|
| Parameter column should be final. |
93
|
|
| Line is longer than 80 characters. |
94
|
|
| Line is longer than 80 characters. |
96
|
|
| Line is longer than 80 characters. |
97
|
|
| 'else' is not preceded with whitespace. |
98
|
|
| '}' is not followed by whitespace. |
98
|
|
| 'else' is not followed by whitespace. |
98
|
|
| '{' is not preceded with whitespace. |
98
|
|
| Line is longer than 80 characters. |
99
|
|
| Line is longer than 80 characters. |
100
|
|
| Line has trailing spaces. |
106
|
|
| Missing a Javadoc comment. |
107
|
|
| Method 'keyPressed' is not designed for extension - needs to be abstract, final or empty. |
109
|
|
| Parameter e should be final. |
109
|
|
| Line is longer than 80 characters. |
115
|
|
| Parameter e should be final. |
119
|
|
| '{' is not followed by whitespace. |
119
|
|
| '}' is not preceded with whitespace. |
119
|
|
| Parameter e should be final. |
120
|
|
| '{' is not followed by whitespace. |
120
|
|
| '}' is not preceded with whitespace. |
120
|
|
| Method 'stateChanged' is not designed for extension - needs to be abstract, final or empty. |
135
|
|
| Parameter e should be final. |
135
|
|
| Line has trailing spaces. |
141
|
|
| Missing a Javadoc comment. |
142
|
|
| 'try' is not followed by whitespace. |
143
|
|
| '{' is not preceded with whitespace. |
143
|
|
| Line contains a tab character. |
144
|
|
| 'catch' is not preceded with whitespace. |
145
|
|
| '}' is not followed by whitespace. |
145
|
|
| 'catch' is not followed by whitespace. |
145
|
|
| '{' is not preceded with whitespace. |
145
|
|
| '{' is not followed by whitespace. |
145
|
|
| ';' is not followed by whitespace. |
145
|
|
| '}' is not preceded with whitespace. |
145
|
|
| Line is longer than 80 characters. |
146
|
|
| Line is longer than 80 characters. |
147
|
|
| Line is longer than 80 characters. |
149
|
|
| Line has trailing spaces. |
151
|
|
| Missing a Javadoc comment. |
152
|
|
| Line is longer than 80 characters. |
153
|
|
| Method 'handleQuit' is not designed for extension - needs to be abstract, final or empty. |
158
|
|
| Parameter event should be final. |
158
|
|
| Line has trailing spaces. |
165
|
|
| Missing a Javadoc comment. |
166
|
|
| Line is longer than 80 characters. |
167
|
|
| 'if' construct must use '{}'s. |
168
|
|
| 'try' is not followed by whitespace. |
171
|
|
| '{' is not preceded with whitespace. |
171
|
|
| 'catch' is not preceded with whitespace. |
174
|
|
| '}' is not followed by whitespace. |
174
|
|
| 'catch' is not followed by whitespace. |
174
|
|
| Must have at least one statement. |
174
|
|
| '{' is not followed by whitespace. |
174
|
|
| '}' is not preceded with whitespace. |
174
|
|
| 'if' construct must use '{}'s. |
176
|
|
| Line is longer than 80 characters. |
176
|
|
| Line has trailing spaces. |
179
|
|
| Missing a Javadoc comment. |
180
|
|
| Parameter b should be final. |
180
|
|
| Avoid inline conditionals. |
185
|
|
| Line has trailing spaces. |
192
|
|
| Missing a Javadoc comment. |
193
|
|
| 'else' is not preceded with whitespace. |
197
|
|
| '}' is not followed by whitespace. |
197
|
|
| 'else' is not followed by whitespace. |
197
|
|
| '{' is not preceded with whitespace. |
197
|
|
| Line is longer than 80 characters. |
201
|
|
| Line is longer than 80 characters. |
203
|
|
| Method 'run' is not designed for extension - needs to be abstract, final or empty. |
206
|
|
| Line has trailing spaces. |
215
|
|
| Missing a Javadoc comment. |
216
|
|
| 'if' construct must use '{}'s. |
217
|
|
| 'if' construct must use '{}'s. |
219
|
|
| Line is longer than 80 characters. |
221
|
|
| Line is longer than 80 characters. |
222
|
|
| '+' should be on a new line. |
231
|
|
| Avoid inline conditionals. |
232
|
|
| '+' should be on a new line. |
232
|
|
| '+' is followed by whitespace. |
233
|
|
| '+' should be on a new line. |
233
|
|
| Avoid inline conditionals. |
234
|
|
| '+' should be on a new line. |
234
|
|
| 'if' construct must use '{}'s. |
238
|
|
| '+' should be on a new line. |
240
|
|
| Avoid inline conditionals. |
241
|
|
| '+' should be on a new line. |
241
|
|
| '+' is followed by whitespace. |
242
|
|
| '+' should be on a new line. |
242
|
|
| Avoid inline conditionals. |
243
|
|
| '+' should be on a new line. |
243
|
|
| Line is longer than 80 characters. |
246
|
|
| Line has trailing spaces. |
248
|
|
| Missing a Javadoc comment. |
249
|
|
| 'if' construct must use '{}'s. |
250
|
|
| 'if' construct must use '{}'s. |
252
|
|
| Line is longer than 80 characters. |
254
|
|
| Line is longer than 80 characters. |
255
|
|
| Line has trailing spaces. |
258
|
|
| Missing a Javadoc comment. |
259
|
|
| Line has trailing spaces. |
262
|
|
| Method 'setError' is not designed for extension - needs to be abstract, final or empty. |
263
|
|
| Missing a Javadoc comment. |
263
|
|
| Parameter message should be final. |
263
|
|
| Method 'setStatus' is not designed for extension - needs to be abstract, final or empty. |
267
|
|
| Missing a Javadoc comment. |
267
|
|
| Parameter message should be final. |
267
|
|
| 'if' construct must use '{}'s. |
270
|
|
| Line contains a tab character. |
271
|
|
| Method 'setBusy' is not designed for extension - needs to be abstract, final or empty. |
275
|
|
| Missing a Javadoc comment. |
275
|
|
| Parameter b should be final. |
275
|
|
| Avoid inline conditionals. |
280
|
|
| Method 'scrollStatus' is not designed for extension - needs to be abstract, final or empty. |
282
|
|
| Missing a Javadoc comment. |
282
|
|
| Parameter message should be final. |
282
|
|
| '512' is a magic number. |
286
|
|
| Line has trailing spaces. |
293
|
|
| Missing a Javadoc comment. |
294
|
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
295
|
|
| Missing a Javadoc comment. |
295
|
|
| Parameter e should be final. |
295
|
|
| Avoid inline conditionals. |
297
|
|
| 'if' construct must use '{}'s. |
298
|
|
| 'if' construct must use '{}'s. |
300
|
|
| 'if' construct must use '{}'s. |
302
|
|
| 'if' construct must use '{}'s. |
304
|
|
| Method 'dispose' is not designed for extension - needs to be abstract, final or empty. |
309
|
|
| Missing a Javadoc comment. |
309
|
|
| Line is longer than 80 characters. |
312
|
|
| Line is longer than 80 characters. |
313
|
|
| Avoid inline conditionals. |
313
|
|
| 'try' is not followed by whitespace. |
314
|
|
| '{' is not preceded with whitespace. |
314
|
|
| Line contains a tab character. |
315
|
|
| Line has trailing spaces. |
316
|
|
| 'catch' is not preceded with whitespace. |
316
|
|
| '}' is not followed by whitespace. |
316
|
|
| 'catch' is not followed by whitespace. |
316
|
|
| '{' is not preceded with whitespace. |
316
|
|
| '{' is not followed by whitespace. |
316
|
|
| ';' is not followed by whitespace. |
316
|
|
| '}' is not preceded with whitespace. |
316
|
|
| Line has trailing spaces. |
319
|
|
| Method 'setVisible' is not designed for extension - needs to be abstract, final or empty. |
320
|
|
| Missing a Javadoc comment. |
320
|
|
| Parameter b should be final. |
320
|
|
| Line has trailing spaces. |
325
|
|
| Missing a Javadoc comment. |
326
|
|
| Parameter args should be final. |
326
|
| Error | Line |
|---|
|
| Missing a header - not enough lines in file. |
1
|
|
| Using the '.*' form of import should be avoided - java.awt.*. |
19
|
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
20
|
|
| Utility classes should not have a public or default constructor. |
28
|
|
| Missing a Javadoc comment. |
29
|
|
| '(' is followed by whitespace. |
29
|
|
| Parameter urlText should be final. |
29
|
|
| Line is longer than 80 characters. |
30
|
|
| Line contains a tab character. |
30
|
|
| Parameter usernameText should be final. |
30
|
|
| Line is longer than 80 characters. |
31
|
|
| Line contains a tab character. |
31
|
|
| Parameter passwordText should be final. |
31
|
|
| Line is longer than 80 characters. |
32
|
|
| Line contains a tab character. |
32
|
|
| Parameter loginButton should be final. |
32
|
|
| Parameter debugCheckbox should be final. |
33
|
|
| '20' is a magic number. |
36
|
|
| '20' is a magic number. |
36
|
|
| '20' is a magic number. |
36
|
|
| '3' is a magic number. |
38
|
|
| '3' is a magic number. |
38
|
|
| '3' is a magic number. |
38
|
|
| '3' is a magic number. |
38
|
|
| Inner assignments should be avoided. |
39
|
|
| Inner assignments should be avoided. |
40
|
|
| '6' is a magic number. |
47
|
|
| '6' is a magic number. |
58
|
|
| '6' is a magic number. |
69
|
|
| Missing a Javadoc comment. |
95
|
|
| Parameter iPhotoTable should be final. |
95
|
|
| Parameter galleryTable should be final. |
95
|
|
| '20' is a magic number. |
97
|
|
| '20' is a magic number. |
97
|
|
| '3' is a magic number. |
100
|
|
| '3' is a magic number. |
100
|
|
| '3' is a magic number. |
100
|
|
| '3' is a magic number. |
100
|
|
| Inner assignments should be avoided. |
101
|
|
| '3' is a magic number. |
113
|
|
| '3' is a magic number. |
114
|
|
| '3' is a magic number. |
120
|
|
| Line is longer than 80 characters. |
123
|
|
| '3' is a magic number. |
125
|
|
| '3' is a magic number. |
126
|
|
| Line is longer than 80 characters. |
132
|
|
| Missing a Javadoc comment. |
132
|
|
| Parameter status should be final. |
132
|
|
| Parameter compareButton should be final. |
132
|
|
| Parameter buttonSwapPanel should be final. |
132
|
|
| Parameter cancelButton should be final. |
132
|
|
| Parameter uploadButton should be final. |
132
|
|
| '20' is a magic number. |
134
|
|
| '20' is a magic number. |
134
|
|
| '20' is a magic number. |
134
|
|
| '3' is a magic number. |
137
|
|
| '3' is a magic number. |
137
|
|
| '3' is a magic number. |
137
|
|
| '3' is a magic number. |
137
|
|
| Inner assignments should be avoided. |
138
|
|
| '4' is a magic number. |
139
|
|
| Line is longer than 80 characters. |
145
|
|
| Line has trailing spaces. |
148
|
|
| Line is longer than 80 characters. |
149
|
|
| Line is longer than 80 characters. |
153
|
|
| Line has trailing spaces. |
154
|
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
